Snowflake COPY INTO target columns, select items and optional alias #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Apr 11, 2025
src/dialect/snowflake.rs
Outdated
Comment on lines
881
to
889
| match parser.next_token().token { | ||
| Token::Comma => { | ||
| // continue | ||
| } | ||
| _ => { | ||
| parser.prev_token(); // need to move back | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
could we do something like this in order to avoid the token clone here?
if matches!(parser.peek_token_ref(), Token::Comma) {
parser.advance()
} else {
break
}There was a problem hiding this comment.
Great idea! I included it in the latest commit.
iffyio
changed the title
iffyio
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following in Snowflake's COPY INTO:
ASkeyword is optional when specifying an alias for the stage in the data transformation query